Skip to content

Conversation

Planeshifter
Copy link

  • support for typed array inputs
  • do not mutate by default (-> new copy option)
  • accessor and dtype options
  • tests
  • switch from coveralls to codecov.io
  • updated dotfiles, Makefile etc.

Open question:
Shall we support matrix inputs? If so, how should they be treated? Return all unique columns / rows or all unique elements from the underlying data store as a simple array? Or not necessary at all?

Pull request resolves compute-io/todo#120 and compute-io/todo#35

@kgryte
Copy link
Contributor

kgryte commented Dec 16, 2015

For matrices, return as a linear array according to a specified dtype.

@kgryte
Copy link
Contributor

kgryte commented Dec 16, 2015

How do you feel about returning indices? See compute-find.

@kgryte
Copy link
Contributor

kgryte commented Dec 16, 2015

And do we want to support preserving the order of occurrence? Right now, results are returned sorted. If we do want to preserve order, then will need to use an additional (alternative) algo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix unique

2 participants