Skip to content

Fix dictionary check action and standardise the make command we run #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Sep 1, 2020
Merged

Fix dictionary check action and standardise the make command we run #1647

merged 30 commits into from
Sep 1, 2020

Conversation

@peternewman
Copy link
Collaborator

No description provided.

@peternewman
Copy link
Collaborator Author

This isn't catching the failure I thought it might. This fails:
https://github.com/codespell-project/codespell/runs/999123609?check_suite_focus=true

This doesn't:
https://github.com/codespell-project/codespell/runs/1003544298?check_suite_focus=true

But the equivalent Travis does.

Is it actually that pytest is missing or something?

@peternewman
Copy link
Collaborator Author

It is indeed pytest:
https://github.com/codespell-project/codespell/runs/1039801917

@peternewman peternewman changed the title Standardise the make command we run Fix dictionary check action and standardise the make command we run Aug 28, 2020
peternewman
peternewman commented Aug 28, 2020
View reviewed changes
peternewman
peternewman commented Aug 28, 2020
View reviewed changes
@peternewman peternewman marked this pull request as ready for review August 28, 2020 04:19
@peternewman peternewman requested a review from larsoner August 28, 2020 04:19
@peternewman peternewman mentioned this pull request Aug 28, 2020
Merged
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
peternewman and others added 2 commits September 1, 2020 04:25
@peternewman peternewman requested a review from larsoner September 1, 2020 13:34
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
@peternewman peternewman requested a review from larsoner September 1, 2020 15:27
@larsoner larsoner merged commit e4b648f into master Sep 1, 2020
@larsoner
Copy link
Member

larsoner commented Sep 1, 2020

Thanks @peternewman

@larsoner larsoner deleted the peternewman-makefile-standardisation branch September 1, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner Awaiting requested review from larsoner

1 more reviewer

@lurch lurch lurch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@larsoner larsoner

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peternewman @larsoner @lurch