Add various new words and suggestions for existing typos #1636
Conversation
I couldn't decide which hyphenation/spacing/none it should have
peternewman
changed the title
peternewman
changed the title
|
Blocked behind #1647 as I'd like to test it catches these ones too. |
Resync with master
It does indeed. |
| automatizes->automates | ||
| backword->backward | ||
| backwords->backwards | ||
| bale->able |
There was a problem hiding this comment.
And kale, dale, male etc. None of those letters are close to B though. I really just wanted to cover the transposing of two characters from one perfectly valid word ( https://en.wikipedia.org/wiki/Baler ) to another more likely one. I suspect male might be more likely than pale anyway if we went down that route.
There was a problem hiding this comment.
Pale just came to my mind, because there is a german dialect, which doesn't distinguish between b or p, and d or t 😄
Close on the keyboard would be vale. I just wanted to prevent people from auto-correcting something they didn't want to (yes i know interactive mode).
There was a problem hiding this comment.
Could also suggest bale->bald ?
There was a problem hiding this comment.
Personally I don't think vaguely infrequent rare valid words should suggest similar but unrelated ones unless there are very strong arguments for it, bald seems the only likely typo we've come up with. I'd suggest vale is as infrequent as bale.
I think also the frequency stats are very telling (I wasn't too far off with vale; bald is still pretty rare):
http://app.aspell.net/lookup?dict=en_US&words=bale%0D%0Aable%0D%0Avale%0D%0Abald%0D%0Apale%0D%0Amale%0D%0Adale%0D%0Akale%0D%0Asale
Between those and the fact it's just a transposition, so not even a real typo, I'd really like to leave it as is.
I think the auto-correct solution is to add what we dropped when we went to multi dictionary and have everything in rare (and names and informal) offer corrections to itself automatically). I can pull it out to a separate PR until that's been done if that would keep you two happy.
There was a problem hiding this comment.
You obviously understand this project much better than I do; I don't have strong opinions either way.
| accessoirez->accessorize, accessories, | ||
| accessort->accessor | ||
| accesss->access | ||
| accesssor->accessor |
There was a problem hiding this comment.
Could also suggest accesssor->access or (if that's not too far outside the scope of this PR)
Should accessor->access or maybe be in the code dictionary?
There was a problem hiding this comment.
Could also suggest
accesssor->access or(if that's not too far outside the scope of this PR)
I think that should be a separate PR if it goes in, but you're saying you typed an s instead of a space seems rather unlikely to be. Some real world examples would be good again.
Should
accessor->access ormaybe be in the code dictionary?
Yes if it was to go in. There seem to be enough examples of those words together that it's plausible. But probably one for a separate PR given this one is getting big. Why don't you do the honours?
There was a problem hiding this comment.
Sorry if I made too many suggestions, I'm happy for you to just ignore any comments I made, as you see fit.
codespell_lib/data/dictionary.txt
Outdated
| ninimum->minimum | ||
| ninjs->ninja | ||
| ninteenth->nineteenth | ||
| ninties->1990s |
There was a problem hiding this comment.
Oh wow, this seems like a bit of an extreme "correction"! Should probably just be ninties->nineties ?
You wouldn't really want "My grandma lived into her ninties" to be corrected to "My grandma lived into her 1990s" 🤣
EDIT: Also, perhaps the ninty->ninety just below here should be ninty->ninety, minty,?
There was a problem hiding this comment.
Good spot, do you want to open a new PR for them given they're entirely unrelated to this one and it's growing rather large already? I suspect they should be in informal probably. There are probably 80s/70s etc variants too.
There was a problem hiding this comment.
Should probably just be ninties->nineties ?
I've added that option as the primary choice.
EDIT: Also, perhaps the
ninty->ninetyjust below here should beninty->ninety, minty,?
Done this.
There was a problem hiding this comment.
There are probably 80s/70s etc variants too.
Nope 🙂
$ grep '[0-9]' codespell_lib/data/dictionary.txt
1nd->1st
2rd->2nd
2st->2nd
3nd->3rd
3st->3rd
nd->and, 2nd,
ninties->1990s
p0enis->penis
sh1sum->sha1sum
UTF8ness->UTF-8-ness
| calcutated->calculated | ||
| caleed->called | ||
| calender->calendar | ||
| calenders->calendars |
4 participants
No description provided.