Skip to content

Fix getTemplate types #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2019
Merged

Fix getTemplate types #54

merged 1 commit into from
Dec 2, 2019

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Dec 1, 2019 •
edited
Loading

Since dependencies & devDependencies are optional in package.json and they're getting a default value on line 62, this should be reflected in the type of the arguments.

CC: @CompuIves

@MichaelDeBoey MichaelDeBoey mentioned this pull request Dec 1, 2019
Merged
CompuIves
CompuIves approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@CompuIves CompuIves merged commit 6ee1c3a into codesandbox:master Dec 2, 2019
@MichaelDeBoey MichaelDeBoey deleted the fix-getTemplate-types branch December 2, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CompuIves CompuIves CompuIves approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelDeBoey @CompuIves