Skip to content

Fix parsedConfigurations type #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 4, 2019
Merged

Fix parsedConfigurations type #3109

merged 6 commits into from
Dec 4, 2019

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Dec 1, 2019

No description provided.

@lbogdan
Copy link
Contributor

lbogdan commented Dec 1, 2019 •
edited
Loading

Build for latest commit e784f54 is at https://pr3109.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the fix-parsedConfigurations-type branch from d0f6dfd to 4aa953b Compare December 1, 2019 18:51
@MichaelDeBoey MichaelDeBoey force-pushed the fix-parsedConfigurations-type branch from a485862 to c178efa Compare December 1, 2019 20:13
CompuIves
CompuIves reviewed Dec 1, 2019
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the typings! I left 2 questions.

@MichaelDeBoey MichaelDeBoey force-pushed the fix-parsedConfigurations-type branch from 99b9563 to c178efa Compare December 1, 2019 20:33
@lbogdan lbogdan temporarily deployed to pr3109 December 1, 2019 20:34 Inactive
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Dec 1, 2019

@CompuIves All green now 🙂

If we can get codesandbox/codesandbox-importers#54 to be merged, I can revert some type changes (L35) in this one and then this one's good to be merged too 🙂

@CompuIves
Copy link
Member

CompuIves commented Dec 2, 2019

Nice! I've published those changes as 2.1.11

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Dec 2, 2019

@CompuIves Hmmm only build on drone seems to fail, but the error-message doesn't make sense.

Maybe I need to update the cache to a new version? 🤔

@MichaelDeBoey MichaelDeBoey force-pushed the fix-parsedConfigurations-type branch from f513d70 to cca090e Compare December 2, 2019 10:48
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Dec 2, 2019

Seems like merging after your beaf88f commit was causing the drone error, so rebased and fixed it 🙂

@lbogdan lbogdan temporarily deployed to pr3109 December 2, 2019 11:02 Inactive
@lbogdan lbogdan temporarily deployed to pr3109 December 2, 2019 13:28 Inactive
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Dec 2, 2019

@CompuIves All green now 🙂

@MichaelDeBoey MichaelDeBoey force-pushed the fix-parsedConfigurations-type branch from 77ae815 to d9f4222 Compare December 3, 2019 19:55
@lbogdan lbogdan temporarily deployed to pr3109 December 3, 2019 21:03 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the fix-parsedConfigurations-type branch from d9f4222 to adc9571 Compare December 3, 2019 23:29
@MichaelDeBoey MichaelDeBoey force-pushed the fix-parsedConfigurations-type branch from adc9571 to 6d849c7 Compare December 4, 2019 09:36
@lbogdan lbogdan temporarily deployed to pr3109 December 4, 2019 09:45 Inactive
christianalfoni
christianalfoni requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify correctly if parsed configuration is actually there

@christianalfoni
Copy link
Contributor

christianalfoni commented Dec 4, 2019

I have tested changing template of a sandbox, looks good! 👍 😄

@christianalfoni christianalfoni merged commit b6f0d96 into codesandbox:master Dec 4, 2019
@MichaelDeBoey MichaelDeBoey deleted the fix-parsedConfigurations-type branch December 4, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianalfoni christianalfoni christianalfoni approved these changes

@CompuIves CompuIves Awaiting requested review from CompuIves

+1 more reviewer

@arthurdenner arthurdenner arthurdenner left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelDeBoey @lbogdan @CompuIves @christianalfoni @arthurdenner