Skip to content

Conversation

@DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented May 12, 2022

Second attempt at #6672

Still have to figure out what actually went wrong so please don't merge this yet

Closes #6630

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e50e66:

Sandbox Source
Notifications Test Configuration
amazing-pond-xnr55d Issue #6630
fervent-bouman-o4ltiu Issue #6630

@lbogdan lbogdan temporarily deployed to pr6687 May 12, 2022 08:42 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented May 12, 2022

Build for latest commit 2e50e66 is at https://pr6687.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr6687 May 12, 2022 09:31 Inactive
@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented May 12, 2022

Preview is still failing, not sure how to fix this as there's no errors cc @CompuIves

It was a server issue, fixed on staging, waiting for production deploy

@DeMoorJasper DeMoorJasper marked this pull request as ready for review May 19, 2022 15:00
@DeMoorJasper DeMoorJasper merged commit 5d96dde into master May 19, 2022
@DeMoorJasper DeMoorJasper deleted the revert-6685-revert-6672-fix/eslint-ts-literals branch May 19, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eslint throws when parsing TypeScript's Template Literal Types

3 participants