Skip to content

Conversation

@DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented May 3, 2022

What kind of change does this PR introduce?

Fixes ESLint typescript Template Literal Types by updating typescript

Closes #6630

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0f5cdc:

Sandbox Source
Notifications Test Configuration
stoic-lamarr-mzyrjc Issue #6630
weathered-framework-68hg8m Issue #6630

@lbogdan lbogdan temporarily deployed to pr6672 May 3, 2022 16:11 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented May 3, 2022

Build for latest commit b0f5cdc is at https://pr6672.build.csb.dev/s/new.

@danilowoz
Copy link
Contributor

danilowoz commented May 4, 2022

@DeMoorJasper if you'd like to update the editor typescript version, I guess you need to do this (#6498), instead of the main package version. Plus, by updating the main package, I think you will need to fix a few typescheck in the codebase, due to new features & fixes from the new ts version.

I'd confirm with @CompuIves, what is the right way to update it.

@DeMoorJasper
Copy link
Member Author

@danilowoz Unfortunately in this case that's not true as it would already work in that case.

I've tested it and it works after this PR but not before. The eslint plugin also just uses regular requires from what I could tell so I assume everything is bundled from the local node_modules

@lbogdan lbogdan temporarily deployed to pr6672 May 6, 2022 19:18 Inactive
@DeMoorJasper DeMoorJasper merged commit d356356 into master May 12, 2022
@DeMoorJasper DeMoorJasper deleted the fix/eslint-ts-literals branch May 12, 2022 06:26
DeMoorJasper added a commit that referenced this pull request May 12, 2022
DeMoorJasper added a commit that referenced this pull request May 12, 2022
@DeMoorJasper DeMoorJasper restored the fix/eslint-ts-literals branch May 12, 2022 07:48
DeMoorJasper added a commit that referenced this pull request May 12, 2022
DeMoorJasper added a commit that referenced this pull request May 19, 2022
* Revert "Revert "fix: ESLint typescript Template Literal Types (#6672)" (#6685)"

This reverts commit 68dcbf0.

* revert some ts updates

* Revert "revert some ts updates"

This reverts commit b383241.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eslint throws when parsing TypeScript's Template Literal Types

4 participants