-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: ESLint typescript Template Literal Types #6672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0f5cdc:
|
|
Build for latest commit b0f5cdc is at https://pr6672.build.csb.dev/s/new. |
|
@DeMoorJasper if you'd like to update the editor typescript version, I guess you need to do this (#6498), instead of the main package version. Plus, by updating the main package, I think you will need to fix a few typescheck in the codebase, due to new features & fixes from the new ts version. I'd confirm with @CompuIves, what is the right way to update it. |
|
@danilowoz Unfortunately in this case that's not true as it would already work in that case. I've tested it and it works after this PR but not before. The eslint plugin also just uses regular requires from what I could tell so I assume everything is bundled from the local node_modules |
This reverts commit d356356.
What kind of change does this PR introduce?
Fixes ESLint typescript Template Literal Types by updating typescript
Closes #6630