Skip to content

Privacy policy followup #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2020
Merged

Privacy policy followup #3924

merged 3 commits into from
Apr 30, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Apr 17, 2020 •
edited
Loading

Follow-up of #3815

  • Use early return
  • Cleanup Privacy toast

@lbogdan
Copy link
Contributor

lbogdan commented Apr 17, 2020 •
edited
Loading

Build for latest commit b2c7c4f is at https://pr3924.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch 2 times, most recently from 83817f6 to fbed333 Compare April 17, 2020 09:22
CompuIves
CompuIves reviewed Apr 17, 2020
View reviewed changes
@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from fbed333 to 5411608 Compare April 17, 2020 10:41
@lbogdan lbogdan temporarily deployed to pr3924 April 17, 2020 10:49 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from 543401b to 9f984fd Compare April 17, 2020 10:50
@lbogdan lbogdan temporarily deployed to pr3924 April 17, 2020 10:57 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from 9f984fd to 2173440 Compare April 17, 2020 12:03
@MichaelDeBoey MichaelDeBoey requested a review from CompuIves April 17, 2020 12:03
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Apr 17, 2020

Build fails due to #3908

@lbogdan lbogdan temporarily deployed to pr3924 April 17, 2020 12:09 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from f3722fe to 55a111a Compare April 17, 2020 14:34
@lbogdan lbogdan temporarily deployed to pr3924 April 17, 2020 14:41 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from 55a111a to dce7cce Compare April 17, 2020 16:08
@lbogdan lbogdan temporarily deployed to pr3924 April 17, 2020 16:15 Inactive
@SaraVieira
Copy link
Contributor

SaraVieira commented Apr 18, 2020

Hey!

There has been a conflict and I don't know how to fix it :(

@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from dce7cce to 7100397 Compare April 18, 2020 15:37
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Apr 18, 2020

@SaraVieira Rebased onto upstream/master 🙂

@lbogdan lbogdan temporarily deployed to pr3924 April 18, 2020 15:43 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from 7100397 to 56502cc Compare April 22, 2020 00:30
@lbogdan lbogdan temporarily deployed to pr3924 April 22, 2020 00:38 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the privacy-policy-followup branch from 56502cc to b2c7c4f Compare April 29, 2020 19:26
@CompuIves
Copy link
Member

CompuIves commented Apr 30, 2020

Great!

@CompuIves CompuIves merged commit d2cd45c into codesandbox:master Apr 30, 2020
@MichaelDeBoey MichaelDeBoey deleted the privacy-policy-followup branch April 30, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CompuIves CompuIves Awaiting requested review from CompuIves

Assignees

No one assigned

Labels

📚 Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelDeBoey @lbogdan @SaraVieira @CompuIves