Extract showPrivacyPolicyNotification action

Author: MichaelDeBoey

packages/app/src/app/overmind/internalActions.ts

@@ -509,7 +509,7 @@ export const handleError: Action<{
   });
 };
 
-export const trackCurrentTeams: AsyncAction = async ({ state, effects }) => {
+export const trackCurrentTeams: AsyncAction = async ({ effects }) => {
   const { me } = await effects.gql.queries.teams({});
   if (me) {
     effects.analytics.setGroup(
@@ -522,3 +522,30 @@ export const trackCurrentTeams: AsyncAction = async ({ state, effects }) => {
     );
   }
 };
+
+const seenTermsKey = 'ACCEPTED_TERMS_CODESANDBOX';
+export const showPrivacyPolicyNotification: Action = ({ effects, state }) => {
+  if (effects.browser.storage.get(seenTermsKey) || state.isFirstVisit) {
+    return;
+  }
+
+  effects.analytics.track('Saw Privacy Policy Notification');
+  effects.notificationToast.add({
+    message:
+      'Hello, our privacy policy has been updated recently. What’s new? CodeSandbox emails. Please read and reach out.',
+    title: 'Updated Privacy',
+    status: NotificationStatus.NOTICE,
+    sticky: true,
+    actions: {
+      primary: [
+        {
+          label: 'Open Privacy Policy',
+          run: () => {
+            window.open('https://codesandbox.io/legal/privacy', '_blank');
+          },
+        },
+      ],
+    },
+  });
+  effects.browser.storage.set(seenTermsKey, true);
+};

packages/app/src/app/overmind/onInitialize.ts

@@ -1,12 +1,10 @@
-import { NotificationStatus } from '@codesandbox/notifications';
 import { OnInitialize } from '.';
 
 export const onInitialize: OnInitialize = async (
   { state, effects, actions },
   overmindInstance
 ) => {
   const provideJwtToken = () => state.jwt || effects.jwt.get();
-  const seenTermsKey = 'ACCEPTED_TERMS_CODESANDBOX';
 
   state.isFirstVisit = Boolean(
     !effects.jwt.get() && !effects.browser.storage.get('hasVisited')
@@ -107,28 +105,5 @@ export const onInitialize: OnInitialize = async (
 
   effects.preview.initialize(overmindInstance.reaction);
 
-  // show terms message on first visit since new terms
-  if (effects.browser.storage.get(seenTermsKey) || state.isFirstVisit) {
-    return;
-  }
-
-  effects.analytics.track('Saw Privacy Policy Notification');
-  effects.notificationToast.add({
-    message:
-      'Hello, our privacy policy has been updated recently. What’s new? CodeSandbox emails. Please read and reach out.',
-    title: 'Updated Privacy',
-    status: NotificationStatus.NOTICE,
-    sticky: true,
-    actions: {
-      primary: [
-        {
-          label: 'Open Privacy Policy',
-          run: () => {
-            window.open('https://codesandbox.io/legal/privacy', '_blank');
-          },
-        },
-      ],
-    },
-  });
-  effects.browser.storage.set(seenTermsKey, true);
+  actions.internal.showPrivacyPolicyNotification();
 };