Skip to content

🔨 Switch Dashboard/Content to use useOvermind #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

🔨 Switch Dashboard/Content to use useOvermind #3539

wants to merge 2 commits into from

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Feb 18, 2020 •
edited
Loading

#3518 Needs to be merged first

Follow-up of #2863

Things I did extra:

  • Add react-virtualized types
  • Put DragLayer, SandboxCard & Selection inside SandboxGrid, since they're only used as a child component
  • Make Content, DragLayerComponent (was called CustomDragLayer), Row & Selection a FunctionComponent
  • Put all styles into the elements.ts file
  • Export Content by a named export instead of a default export

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Feb 18, 2020
@lbogdan
Copy link
Contributor

lbogdan commented Feb 18, 2020 •
edited
Loading

Build for latest commit 63ce193 is at https://pr3539.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch 6 times, most recently from 41e9ff1 to cce6e97 Compare February 18, 2020 17:11
@MichaelDeBoey MichaelDeBoey changed the title 🔨 Switch Dashboard/Content to use useOvermind [DRAFT] 🔨 Switch Dashboard/Content to use useOvermind Feb 18, 2020
@lbogdan lbogdan temporarily deployed to pr3539 February 18, 2020 17:19 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from cce6e97 to 4715dbe Compare February 20, 2020 20:17
@lbogdan lbogdan temporarily deployed to pr3539 February 20, 2020 20:26 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from 4715dbe to 9c3176e Compare February 23, 2020 17:06
@lbogdan lbogdan temporarily deployed to pr3539 February 23, 2020 17:12 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from 9c3176e to 36fb229 Compare March 5, 2020 01:27
@lbogdan lbogdan temporarily deployed to pr3539 March 5, 2020 01:37 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from 36fb229 to decc695 Compare March 26, 2020 10:25
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from decc695 to eb954eb Compare April 4, 2020 16:09
@lbogdan lbogdan temporarily deployed to pr3539 April 4, 2020 16:19 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from eb954eb to ad73a8b Compare April 7, 2020 17:13
@lbogdan lbogdan temporarily deployed to pr3539 April 7, 2020 17:19 Inactive
@MichaelDeBoey MichaelDeBoey marked this pull request as draft April 8, 2020 20:50
@MichaelDeBoey MichaelDeBoey changed the title [DRAFT] 🔨 Switch Dashboard/Content to use useOvermind 🔨 Switch Dashboard/Content to use useOvermind Apr 8, 2020
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from ad73a8b to 4c153ca Compare April 29, 2020 19:08
@lbogdan lbogdan temporarily deployed to pr3539 April 29, 2020 19:18 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/Dashboard-Content branch from 4c153ca to 63ce193 Compare April 30, 2020 13:37
@SaraVieira
Copy link
Contributor

SaraVieira commented May 18, 2020

Hey!

Sorry for the delay but we are now writing a new dashboard so it doesn't really make sense to merge this and create conflicts

@SaraVieira SaraVieira closed this May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira