🔨 Refactor, 🧠 Overmind, Hactoberfest | packages/app/src/app/pages/Dashboard/Content/DragLayer/SelectedSandboxItems #2863
Conversation
…ms/index to Typescript and useOvermind
…ms/AnimatedSandboxItem to Typescript and functional component with hook
…ms/element to Typescript
|
Build for latest commit 560923f is at https://pr2863.build.csb.dev/s/new. |
br1anchen
changed the title
br1anchen
changed the title
| left={left} | ||
| top={top} |
There was a problem hiding this comment.
Why are you not passing this one down anymore?
There was a problem hiding this comment.
The reason I removed these props is because they are not used any where by any components under <SelectedSandboxItems />.
You can see they are forwarded in here to <AnimatedSandboxItem />, but <AnimatedSandboxItem /> does not use them and not expects them either here.
It might be a bug for <AnimatedSandboxItem /> not using them, then we can fix it with more context knowledge.
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
I don't know if it does need changes but its to keep track of the PR's better
|
@SaraVieira Thanks for review. No problem to request changes. It is a good way to track it 👍 |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
This looks great! 😄 👍
Tested:
- Dragging single sandbox
- Dragging multiples sandboxes
- Drop sandbox in trash
5 participants
What kind of change does this PR introduce?
Refactor for #2621 @Saeris @christianalfoni
What is the current behavior?
They are in
jswithcerebralWhat is the new behavior?
They are changed to
tsfiles withOvermindWhat steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
yarn testyarn lintyarn typecheckyarn start, go toDashboard, drag things no errorChecklist