Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Follow-up of #2535 & #2818

Things I did extra:

  • Change deleteEnvironmentVariable's signature to accept a string instead of { name: string }, because it only has 1 argument
  • Change onBrowserFromPortOpened's signature to accept a ServerPort instead of { port: ServerPort }, because it only has 1 argument
  • Extract ControlContainer, OpenPorts, RunScripts, SecretKeys & Status out of Server
  • Put all styles into the elements.ts file
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through
  • Make EnvEntry, EnvModal, RunScripts (was called Tasks) & Status a FunctionComponent
  • Use FunctionComponent instead of React.FC, since it's the same, but FunctionComponent is a bit clearer I think

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Feb 4, 2020
@lbogdan lbogdan temporarily deployed to pr3461 February 4, 2020 10:36 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Feb 4, 2020

Build for latest commit 11c5750 is at https://pr3461.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3461 February 4, 2020 10:57 Inactive
@lbogdan lbogdan temporarily deployed to pr3461 February 5, 2020 17:06 Inactive
@lbogdan lbogdan temporarily deployed to pr3461 February 5, 2020 23:59 Inactive
@SaraVieira
Copy link
Contributor

Hey!

I am so sorry for the work but right now we can't accept changes to the sidebar since we will be releasing a new version of the sidebar next week and all this code will be deleted

I know you made some changes also to the actions but the work it would be to make it work in the new one two days before deployment doesn't make sense right now

I'm sorry we didn't make this public :/

@SaraVieira SaraVieira closed this Feb 13, 2020
@MichaelDeBoey MichaelDeBoey deleted the overmind/Server branch May 1, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants