Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Follow-up of #2878

Things I did extra:

  • Change onModeChanged, onLiveMode & sendLiveMode's signature to get its argument types directly from RoomInfo instead of hardcoding them
  • Change onAddEditorClicked & onFollow's signature to accept a string instead of { liveUserId: string }, because it only has 1 argument
  • Change onRemoveEditorClicked's signature to accept a string instead of { liveUserId: string }, because it only has 1 argument (data is never passed)
  • Put all styles into the elements.ts file
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through
  • Extract FollowButton, LiveMode, MakeEditorButton, MakeSpectatorButton & Preferences from LiveInfo

@MichaelDeBoey MichaelDeBoey added 🔴 Live 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Feb 1, 2020
@lbogdan lbogdan temporarily deployed to pr3444 February 1, 2020 14:45 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Feb 1, 2020

Build for latest commit 5bdd620 is at https://pr3444.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3444 February 5, 2020 17:03 Inactive
@lbogdan lbogdan temporarily deployed to pr3444 February 6, 2020 00:22 Inactive
@lbogdan lbogdan temporarily deployed to pr3444 February 6, 2020 20:04 Inactive
@SaraVieira
Copy link
Contributor

Same idea as #3461

@SaraVieira SaraVieira closed this Feb 13, 2020
@MichaelDeBoey MichaelDeBoey deleted the overmind/LiveInfo branch May 1, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants