Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jan 16, 2020

Follow-up of #2729

Things I did extra:

  • Change profileMounted's signature to accept a string instead of { username: string }, because it only has 1 argument
  • Put all styles into the elements.ts file
  • Fix Profile's props by using react-router-dom's RouteComponentProps generic instead of hardcoding it
  • Export Profile by a named export instead of a default export

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 16, 2020
@lbogdan
Copy link
Contributor

lbogdan commented Jan 16, 2020

Build for latest commit 78e85ee is at https://pr3352.build.csb.dev/s/new.

@SaraVieira
Copy link
Contributor

Looks good! Thank you!

@SaraVieira SaraVieira merged commit 012220f into codesandbox:master Jan 27, 2020
@MichaelDeBoey
Copy link
Contributor Author

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/Profile branch January 27, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants