🔨 Refactored 🧠 Overmind Hacktober | /app/pages/Profile/index.js #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/idfdv33c3 |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
CompuIves
approved these changes
Oct 17, 2019
Member
CompuIves
left a comment
CompuIves
left a comment
There was a problem hiding this comment.
This looks great! Thanks a lot for the contribution!
84 tasks
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
/app/pages/Profile/index.jsto use TS/hooks/Overmind.Added typings for
react-helmetandreact-router-dom, which necessitated changes in some other files.@Saeris @christianalfoni
What is the current behavior?
#2621
What steps did you take to test this? This is required before we can merge.
yarn lint && yarn typecheckChecklist