Layout components #3277
Merged
Layout components #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit 2091157 is at https://pr3277.build.csb.dev/s/new. |
MichaelDeBoey
suggested changes
Jan 7, 2020
MichaelDeBoey
suggested changes
Jan 7, 2020
| // valid combinations are | ||
| // start | start + end | start + span | span | ||
| // span + end is also possible but not implemented here | ||
| export const Column = styled.div<{ |
Contributor
There was a problem hiding this comment.
Suggested change
| export const Column = styled.div<{ | |
| type ColumnEnd = number | number[]; | |
| type ColumnSpan = number | number[]; | |
| type ColumnStart = number | Array<number | string>; | |
| type ColumnProps = | |
| | { end: ColumnEnd; start: ColumnStart; } | |
| | { span: ColumnSpan; } | |
| | { span: ColumnSpan; start: ColumnStart; } | |
| | { start: ColumnStart; }; | |
| export const Column = styled.div<ColumnProps>( |
Contributor
Author
There was a problem hiding this comment.
what does this improve?
Contributor
There was a problem hiding this comment.
This is implementing the Props like you said in your comments 🙂
Contributor
Author
There was a problem hiding this comment.
Got it. Implementing it this way would give errors on the missing prop in each, right?
repro (see end prop): https://codesandbox.io/s/funny-pare-zswfv
Contributor
Author
There was a problem hiding this comment.
- This is not a blocker, so I'm merging the PR but will continue to improve the types
Co-Authored-By: Michaël De Boey <[email protected]>
MichaelDeBoey
suggested changes
Jan 7, 2020
SaraVieira
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grid + Stack
Built on top of #3269