First component for new package: Collapsible #3269
Conversation
…to components-package
…to components-package
|
Build for latest commit f217554 is at https://pr3269.build.csb.dev/s/new. |
|
|
||
| configure(loadStories, module); | ||
| // automatically import all files ending in *.stories.js | ||
| configure(require.context('../src', true, /\.stories\.tsx$/), module); |
There was a problem hiding this comment.
changed the declaration so that we can use their new format, see collapsible/stories.tsx
| alignItems: 'center', | ||
| height: '32px', | ||
| paddingX: 3, | ||
| borderBottom: '1px solid', |
There was a problem hiding this comment.
@SaraVieira This collapsible has too much information about the sidebar, should we just call it a SidebarSection instead, or should we break it into 2 parts where one non-styled part lives in components and the other extends in app/sidebar/?
There was a problem hiding this comment.
Yeah, when adding the animation I think it would make sense to call it SidebarSection
|
Missing animation but all the rest looks good so merging because it creates a lot of foundations |
| step?: number; | ||
| value: number; | ||
| } & Pick<ComponentProps<typeof Input>, 'style'>; | ||
| style?: React.CSSProperties; |
There was a problem hiding this comment.
@siddharthkp This should be reverted (see @SaraVieira's PR)
Built on top of: #3256
First component, lots of concepts introduced here. See changes for comments.