Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Dec 7, 2019

Resubmission of #2855

Follow-up of #2635

Things I did extra:

  • Change likeSandboxToggled's signature to accept a string instead of { id: string }, because it only has 1 argument
  • Extract MaybeTooltip into a separate file
  • Improve LikeHeart's props type

@lbogdan
Copy link
Contributor

lbogdan commented Dec 7, 2019

Build for latest commit 92e2a9a is at https://pr3144.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Dec 7, 2019
@SaraVieira
Copy link
Contributor

Looks good!

Danke :D

@SaraVieira SaraVieira merged commit ec092de into codesandbox:master Dec 8, 2019
@MichaelDeBoey
Copy link
Contributor Author

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/LikeHeart branch December 8, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants