Skip to content

🔨 Switch LikeHeart to use useOvermind #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 17, 2019
Merged

🔨 Switch LikeHeart to use useOvermind #2635

merged 6 commits into from
Oct 17, 2019

Conversation

@vanya829
Copy link
Contributor

@vanya829 vanya829 commented Oct 3, 2019 •
edited
Loading

What kind of change does this PR introduce?

Refactor LikeHeart to functional components with useOvermind hook

Refactor

What is the current behavior?

#2621

What is the new behavior?

What steps did you take to test this?

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 3, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-fork-vanya829-refactor-like-heart.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 3, 2019 21:01 Inactive
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 4, 2019
Saeris
Saeris approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@Saeris Saeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Though for sanity's sake it would be good to get confirmation from @CompuIves that it's normal to have so many deletions for a contributors update to the README file.

@vercel vercel bot temporarily deployed to staging October 4, 2019 07:07 Inactive
@SaraVieira
Copy link
Contributor

SaraVieira commented Oct 7, 2019

@all-contributors please add @vanya829 for code

@allcontributors allcontributors bot mentioned this pull request Oct 7, 2019
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Oct 7, 2019

@SaraVieira

I've put up a pull request to add @vanya829! 🎉

@SaraVieira
Copy link
Contributor

SaraVieira commented Oct 7, 2019

I reverted the contributor changes to add you with the bot to cause less errors

Thank you so much!!

@vercel vercel bot temporarily deployed to staging October 7, 2019 21:48 Inactive
@Saeris
Copy link
Contributor

Saeris commented Oct 17, 2019

Ugh, tried to rebase this branch onto Master to try and fix the broken Integration Tests, ended up inflating the commits somehow. My bad, I'll try to fix this...

@lbogdan lbogdan temporarily deployed to pr2635 October 17, 2019 09:46 Inactive
@Saeris Saeris force-pushed the refactor/like-heart branch from 1185869 to 7330597 Compare October 17, 2019 10:06
christianalfoni
christianalfoni approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

Tested:

  • Like and unlike on a Sandbox
  • Like and unlike on a Profile sandbox

@Saeris Saeris merged commit 3321ac5 into codesandbox:master Oct 17, 2019
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 18, 2019
Closed
@kiliman kiliman mentioned this pull request Oct 18, 2019
Closed
84 tasks
This was referenced Dec 7, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianalfoni christianalfoni christianalfoni approved these changes

+1 more reviewer

@Saeris Saeris Saeris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vanya829 @SaraVieira @Saeris @christianalfoni @lbogdan