Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Resubmission of #2849

Follow-up of #2664

Things I did extra:

  • Rename Helmet.js to Helmet.tsx
  • Put all styles into the elements.ts file
  • Make Button a FunctionComponent

I think this component (DashboardChangelog) can be deleted tho, since it's not used anymore? 🤔

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Dec 7, 2019
@lbogdan
Copy link
Contributor

lbogdan commented Dec 7, 2019

Build for latest commit c31ed7b is at https://pr3142.build.csb.dev/s/new.

@SaraVieira
Copy link
Contributor

Looks good!!!

@SaraVieira SaraVieira merged commit 94b3148 into codesandbox:master Dec 8, 2019
@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I'll create a new PR to delete DashboardChangelog, since it's not used anymore 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/DashboardChangelog branch December 8, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants