Skip to content

🔨 Switch DashboardChangelog to use useOvermind #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🔨 Switch DashboardChangelog to use useOvermind #2849

wants to merge 1 commit into from

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Oct 18, 2019 •
edited
Loading

Follow-up of #2664

Although DashboardChangelog isn't used, so I think this component can be deleted? 🤔

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/DashboardChangelog branch from 0e7436e to 4be691c Compare October 18, 2019 14:29
@Saeris Saeris closed this Oct 18, 2019
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Oct 19, 2019

@Saeris I think this one can be re-opened and merged, like I explained in #2843 (comment).

Here I converted Helmet to a tsx file.
But I also think DashboardChangelog can just be removed, since I don't find any reference where it's used.

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Nov 5, 2019
@MichaelDeBoey MichaelDeBoey mentioned this pull request Dec 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @Saeris