🔨 Switch CLI to use useOvermind #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Contributor
|
Build for latest commit 4d52717 is at https://pr3121.build.csb.dev/s/new. |
christianalfoni
approved these changes
Dec 4, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Looks great! 👍 😄
Tested:
- Opening
cli/login - When logged in it showed the code
- Logged out, now shows login button
- Logged in, shows the code
- Click the code and it selects the whole code
MichaelDeBoey
force-pushed
the
overmind/CLI
branch
from
da67f70 to
d65e854
Compare
MichaelDeBoey
force-pushed
the
overmind/CLI
branch
from
d65e854 to
4d52717
Compare
SaraVieira
reviewed
Dec 8, 2019
| } | ||
|
|
||
| if (loading) { | ||
| if (isLoadingCLI) { |
Contributor
There was a problem hiding this comment.
Where did this come from?
Was it changed in the state?
Contributor
Author
There was a problem hiding this comment.
This was first passed to Prompt as a prop by CLI, but can just be taken from the useOvermind hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #2848
Follow-up of #2623
Things I did extra:
overmindsubscriptions as close as possible to the components itself instead of passing it throughrefforTokenInput'sonClickinstead of using theMouseEvent'stargetCLIby a named export instead of adefault export