Skip to content

🔨 Refactored app/pages/CLI/index.tsx #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

🔨 Refactored app/pages/CLI/index.tsx #2623

merged 1 commit into from
Oct 3, 2019

Conversation

@indifferentghost
Copy link
Contributor

@indifferentghost indifferentghost commented Oct 3, 2019 •
edited
Loading

What kind of change does this PR introduce?

This is part of the requested refactor for hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

Previously it was utilizing inject and hooksObserver from app/componentConnectors.

#2621

What is the new behavior?

Prefers useOvermind over inject and other small stylistic choices mentioned in #2621

What steps did you take to test this?

  • yarn:lint: There were several linting errors, but none relevant to the scope of this PR
  • yarn:test: Ran successfully

Checklist

  • Documentation - N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

I was unable to add the 🔨 Refactor, 🧠 Overmind, or Hacktoberfest labels.

@vercel
Copy link

vercel bot commented Oct 3, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-fork-htmlghozt-refactor.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 3, 2019 12:21 Inactive
@indifferentghost indifferentghost changed the title Refactored app/pages/CLI/index.tsx 🔨Refactored app/pages/CLI/index.tsx Oct 3, 2019
@indifferentghost indifferentghost changed the title 🔨Refactored app/pages/CLI/index.tsx 🔨 Refactored app/pages/CLI/index.tsx Oct 3, 2019
@indifferentghost indifferentghost mentioned this pull request Oct 3, 2019
Closed
84 tasks
SaraVieira
SaraVieira approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dankeee

@SaraVieira
Copy link
Contributor

SaraVieira commented Oct 3, 2019

@all-contributors bot please add HTMLGhozt for code

@SaraVieira SaraVieira merged commit 47099a3 into codesandbox:master Oct 3, 2019
@allcontributors allcontributors bot mentioned this pull request Oct 3, 2019
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Oct 3, 2019

@SaraVieira

I've put up a pull request to add @HTMLGhozt! 🎉

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 3, 2019
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 18, 2019
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaraVieira SaraVieira SaraVieira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@indifferentghost @SaraVieira @Saeris