Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Follow-up of #2759

Things I did extra:

  • Export Prettier by a named export instead of a default export
  • Type Prettier's bindValue function
  • Put all styles into the elements.ts file

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Nov 22, 2019
@lbogdan
Copy link
Contributor

lbogdan commented Nov 22, 2019

Build for latest commit 89537fc is at https://pr3073.build.csb.dev/s/new.

Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 😄 👍

Tested:

  • Open prettier config in preferencer
  • Changed setting and refreshed, it is saved
  • Double checked last arrow config, as it changed bindValue, looks good!

@christianalfoni christianalfoni merged commit b251a32 into codesandbox:master Nov 28, 2019
@MichaelDeBoey MichaelDeBoey deleted the overmind/CodeFormatting branch November 28, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants