Skip to content

Conversation

@NileshPatel17
Copy link
Contributor

What kind of change does this PR introduce?

Refactor code for hacktoberfest #2621

What is the current behavior?

/app/pages/common/Modals/PreferencesModal/CodeFormatting/Prettier/index.js was using inject and observer from app/componentConnectors

What is the new behavior?

uses useOvermind from app/overmind and js file converted to tsx file

What steps did you take to test this? This is required before we can merge.

  1. yarn:test: Ran successfully
  2. yarn:lint: There were several linting errors, but none relevant to the scope of this PR

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 13, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/barn5q4us
🌍 Preview: https://codesandbox-cli-git-fork-nileshpatel17-issue2621-codefor-da7234.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 13, 2019 04:37 Inactive
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 13, 2019
@NileshPatel17 NileshPatel17 force-pushed the issue#2621/CodeFormatting-Prettier branch from 4c22701 to 610ce4a Compare October 14, 2019 07:48
@vercel vercel bot temporarily deployed to staging October 14, 2019 07:48 Inactive
@CompuIves
Copy link
Member

Great, very clean. Thanks a lot!

Tested:

  1. Opening prettier settings
  2. Changing settings
  3. Verify changes are persisted

@CompuIves CompuIves merged commit e11c3ea into codesandbox:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants