Skip to content

🔨 Switch TemplateItem to use useOvermind #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2019
Merged

🔨 Switch TemplateItem to use useOvermind #3070

merged 2 commits into from
Dec 3, 2019

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Nov 22, 2019 •
edited
Loading

Follow-up of #2737

Things I did extra:

  • Just use a single file to not pollute the project files unnecessarily
  • Remove all react-router-dom references, since it's not used in this component
  • Type entryTarget & collectTarget
  • Simplify entryTarget's canDrop, since !props.removedAt will always be true as removedAt isn't a prop and isn't ever passed through & monitor is never null

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Nov 22, 2019
@lbogdan lbogdan temporarily deployed to pr3070 November 22, 2019 14:03 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Nov 22, 2019 •
edited
Loading

Build for latest commit b91a538 is at https://pr3070.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/TemplateItem branch 2 times, most recently from 9add882 to c6509de Compare November 22, 2019 22:56
@lbogdan lbogdan temporarily deployed to pr3070 November 22, 2019 23:10 Inactive
christianalfoni
christianalfoni requested changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of issues! I tested it after fixing the two comments and works great 👍

@lbogdan lbogdan temporarily deployed to pr3070 November 28, 2019 16:41 Inactive
christianalfoni
christianalfoni approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested:

  • Open dashboard
  • Click the "templates" on the sidebar
  • Drag and drop "templates"

Works great! 👍

@christianalfoni christianalfoni merged commit 45970c9 into codesandbox:master Dec 3, 2019
@MichaelDeBoey MichaelDeBoey deleted the overmind/TemplateItem branch December 3, 2019 11:43
CompuIves added a commit that referenced this pull request Dec 4, 2019
@CompuIves
Revert "🔨 Switch TemplateItem to use useOvermind (#3070)"
37223ea 
Fixes #3124

This reverts commit 45970c9.
MichaelDeBoey added a commit to MichaelDeBoey/codesandbox-client that referenced this pull request Dec 4, 2019
@MichaelDeBoey
Revert "Revert "🔨 Switch TemplateItem to use useOvermind (codesandbox…
dadb915 
…#3070)""

This reverts commit 37223ea
@MichaelDeBoey MichaelDeBoey mentioned this pull request Dec 4, 2019
Merged
christianalfoni pushed a commit that referenced this pull request Dec 4, 2019
@MichaelDeBoey @christianalfoni
🔨 Switch TemplateItem to use useOvermind (#3127)
cbfb0ba 
* Revert "Revert "🔨 Switch TemplateItem to use useOvermind (#3070)""

This reverts commit 37223ea

* Fix entryTarget
@MichaelDeBoey MichaelDeBoey mentioned this pull request Feb 14, 2020
Closed
This was referenced Dec 23, 2020
Open
Open
Open
Open
Closed
Open
This was referenced Dec 24, 2020
Open
Open
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Jan 1, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Jan 1, 2024
Open
@adamlaska adamlaska mentioned this pull request Jan 1, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Jan 1, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Jan 1, 2024
Open
@CharaD7 CharaD7 mentioned this pull request Jan 1, 2024
Open
@saurabharch saurabharch mentioned this pull request Jan 1, 2024
Open
@baophucct baophucct mentioned this pull request Jan 2, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Mar 15, 2024
Open
This was referenced Mar 15, 2024
Open
Open
@CharaD7 CharaD7 mentioned this pull request Mar 15, 2024
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Mar 16, 2024
Open
@baophucct baophucct mentioned this pull request Mar 16, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Mar 16, 2024
Open
@saurabharch saurabharch mentioned this pull request Mar 16, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Mar 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianalfoni christianalfoni christianalfoni approved these changes

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @christianalfoni