Skip to content

🔨 Switch CollectionInfo to use useOvermind #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

🔨 Switch CollectionInfo to use useOvermind #2858

wants to merge 2 commits into from

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Oct 18, 2019

Follow-up of #2639

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/CollectionInfo branch from d245e57 to 9cb8ae3 Compare October 18, 2019 14:33
@lbogdan lbogdan temporarily deployed to pr2858 October 18, 2019 16:43 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/CollectionInfo branch from 9cb8ae3 to 47e3e24 Compare October 19, 2019 17:19
@lbogdan lbogdan temporarily deployed to pr2858 October 19, 2019 17:29 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Oct 19, 2019 •
edited
Loading

Build for latest commit 46282d2 is at https://pr2858.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr2858 October 19, 2019 17:56 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/CollectionInfo branch from be41fb7 to 7e36620 Compare October 20, 2019 02:04
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Oct 20, 2019 •
edited
Loading

I think this component (CollectionInfo) can be deleted after @CompuIves' 167365c (since it's not used anymore), no? 🤔

@lbogdan lbogdan temporarily deployed to pr2858 October 20, 2019 02:12 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/CollectionInfo branch from 7e36620 to 01e0c84 Compare November 4, 2019 00:16
@lbogdan lbogdan temporarily deployed to pr2858 November 4, 2019 00:34 Inactive
@MichaelDeBoey MichaelDeBoey added the 🧠 Overmind Indicates that this is related to the app's State Management label Nov 5, 2019
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/CollectionInfo branch from 01e0c84 to 6e3a5d1 Compare November 15, 2019 13:42
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/CollectionInfo branch from 6e3a5d1 to 46282d2 Compare November 15, 2019 13:44
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Nov 15, 2019

Ping @CompuIves @SaraVieira @christianalfoni

@christianalfoni
Copy link
Contributor

christianalfoni commented Nov 20, 2019

Yeah, I can not find any usage of this component. Closing it. Sorry and please reopen if I did anything wrong here 😄

@MichaelDeBoey MichaelDeBoey mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianalfoni christianalfoni Awaiting requested review from christianalfoni

@CompuIves CompuIves Awaiting requested review from CompuIves

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelDeBoey @lbogdan @christianalfoni @Saeris