Skip to content

Conversation

@chinmaychaudhary
Copy link
Contributor

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

/pages/Sandbox/Editor/Header/CollectionInfo/index.js

  1. was using inject and hooksObserver from app/componentConnectors
  2. was written in js and NOT ts.

What is the new behavior?

  1. uses useOvermind from app/overmind
  2. converted to ts

What steps did you take to test this?

Looks like CollectionInfo is not used.

/pages/Sandbox/Editor/index.js imports Header which is exported from /pages/Sandbox/Editor/Header/Header.tsx and NOT /pages/Sandbox/Editor/Header/index.tsx ( which imports CollectionInfo).

ran yarn lint and yarn typecheck

Checklist

  • Documentation: N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table: N/A

@vercel vercel bot temporarily deployed to staging October 4, 2019 05:29 Inactive
@vercel
Copy link

vercel bot commented Oct 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-cl-git-fork-chinmay17-refactor-editor-header-add2b1.codesandbox1.now.sh

Copy link
Contributor

@Saeris Saeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Really good job on refactoring it to Hooks/Typescript! Has my approval from a quick glance at the code. May need to play around with it to be sure it still works as expected.

Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful :)

@SaraVieira SaraVieira merged commit 7dafe74 into codesandbox:master Oct 4, 2019
@chinmaychaudhary
Copy link
Contributor Author

Thank you so much @Saeris @christianalfoni & @SaraVieira for your work and words. Really means a lot. :)

@chinmaychaudhary chinmaychaudhary deleted the refactor-editor-header-collection-info-index branch October 4, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants