Skip to content

🔨 Switch Search to use useOvermind #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

🔨 Switch Search to use useOvermind #2852

wants to merge 2 commits into from

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Oct 18, 2019 •
edited
Loading

Follow-up of #2780 & #2819

@lbogdan lbogdan temporarily deployed to pr2852 October 18, 2019 15:53 Inactive
armujahid
armujahid reviewed Oct 19, 2019
View reviewed changes
@lbogdan
Copy link
Contributor

lbogdan commented Oct 19, 2019 •
edited
Loading

Build for latest commit bd932e4 is at https://pr2852.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr2852 October 19, 2019 17:04 Inactive
SaraVieira
SaraVieira suggested changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the props in the Search Component :/

MichaelDeBoey
MichaelDeBoey commented Oct 20, 2019
View reviewed changes
packages/app/src/app/pages/Search/index.tsx
Comment on lines +42 to +43
type Props = RouteComponentProps;
const Search: FunctionComponent<Props> = ({ history, location }) => {
Copy link
Contributor Author

@MichaelDeBoey MichaelDeBoey Oct 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaraVieira Props are still present.

@lbogdan lbogdan temporarily deployed to pr2852 October 20, 2019 02:19 Inactive
@lbogdan lbogdan temporarily deployed to pr2852 November 4, 2019 00:26 Inactive
@MichaelDeBoey MichaelDeBoey added the 🧠 Overmind Indicates that this is related to the app's State Management label Nov 5, 2019
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Nov 15, 2019

Ping @CompuIves @SaraVieira @christianalfoni

@christianalfoni
Copy link
Contributor

christianalfoni commented Nov 20, 2019

mmm... in master this is already refactored? Sorry 😭 Closing now, please reopen if I misunderstood something

@MichaelDeBoey MichaelDeBoey mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

@christianalfoni christianalfoni Awaiting requested review from christianalfoni

@CompuIves CompuIves Awaiting requested review from CompuIves

1 more reviewer

@armujahid armujahid armujahid left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MichaelDeBoey @lbogdan @christianalfoni @SaraVieira @armujahid @Saeris