refactor: /app/pages/Search/index.js 🔨 Refactor, 🧠 Overmind #2780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/l7zivtqi4 |
84 tasks
armujahid
changed the title
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
christianalfoni
approved these changes
Oct 15, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Looks amazeballs! 😄 👍
Tested:
- Opening search
- Search
- Change view
- Change environment and check
- Change dependencies and check
- Change tags and check
- Open sandbox
Contributor
Author
|
Kindly mark it complete in "Components to be refactored:" section in #2621 |
Contributor
Author
|
Kindly also add me as a contributor for "code" and "Documentation". I have three closed PRs related to code and docs. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
/app/pages/Search/index.js#2621 @Saeris @christianalfoniWhat is the current behavior?
It was using cerebral for state management
What is the new behavior?
It uses Overmind for state management with help of useOvermind hook
What steps did you take to test this? This is required before we can merge.
Checklist