Skip to content

Conversation

@NileshPatel17
Copy link
Contributor

What kind of change does this PR introduce?

Refactor code for hacktoberfest #2621

What is the current behavior?

  1. /app/pages/Profile/index.js was using inject and observer from app/componentConnectors
  2. it is an class component
  3. no type definition for react-router-dom

What is the new behavior?

  1. converted class component to function component
  2. usds ```useOvermind` from app/overmind and converted js file to tsx file
  3. added type definition of react-router-dom to package.json

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. yarn:test: Ran successfully
  2. yarn:lint: There were several linting errors, but none relevant to the scope of this PR

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@lbogdan lbogdan temporarily deployed to pr2821 October 16, 2019 18:10 Inactive
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Can you please fix the linting and type errors?

@SaraVieira
Copy link
Contributor

Also please remove the addition from the package.json as it wasn't added to the yarn.lock

@NileshPatel17
Copy link
Contributor Author

NileshPatel17 commented Oct 20, 2019

just found that /profile/index.js is already being refactored and merged to master. hence this PR should be discarded.
#2729

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 21, 2019
@SaraVieira
Copy link
Contributor

Oh, I am so sorry

Thank you anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants