refactored /app/pages/Profile/index.js to use OverMind and change it … #2804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
CompuIves
reviewed
Oct 17, 2019
| @@ -1,482 +0,0 @@ | |||
| 'use strict'; | |||
Author
There was a problem hiding this comment.
I am trying to add this file again but then it is failing on pre-commit hook!
| @@ -0,0 +1,90 @@ | |||
| /* @flow */ | |||
Contributor
There was a problem hiding this comment.
Suggested change
| /* @flow */ |
Do not need this anymore :)
christianalfoni
requested changes
Oct 17, 2019
Author
|
Bringing back the lru-cache.js file gives error on pre-commit hook |
Contributor
|
Duplicate of #2729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR refactor /app/pages/Profile/index.js to use OverMind and change it to tsx file.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
yarn testsuccessfulyarn lintis not successful but the error is not related to the scope of this PRyarn startsuccessfulChecklist