-
Notifications
You must be signed in to change notification settings - Fork 2.4k
refactored deleteDeploymentModal to use Overmind #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored deleteDeploymentModal to use Overmind #2781
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/4wsle0c2a |
|
Heyo, thanks for contributing! I think a change in the |
|
@CompuIves this is part of Zeit deployment and not possible to test... what happened to our development token? I have reviewed the code and the import, I think we should merge it in. |
Should not really include this file
christianalfoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍 😄
|
This is a duplicate of #2809 |
|
Hey! Thank you so much but seems this one has already been updated :( |
What kind of change does this PR introduce?
This PR Refactors /app/pages/common/Modals/DeleteDeploymentModal/index.js to use Overmind
What steps did you take to test this? This is required before we can merge.
yarn testsuccessfullyyarn lintsuccessfullyyarn typechecksuccessfullyyarn start) and confirmed the app started up okChecklist