🔨 Refactor, 🧠 Overmind Hacktober | DeleteProfileSandboxModal to use useOvermind #2744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/fcmhz21m7 |
Member
|
Heyo! Did you verify that this works? You can do that by going to your profile and trying to delete a profile. You can test it with this url: http://pr2744.build.csb.dev/s/new |
Contributor
Author
|
🙇 Yes that work - apology - i missed fully reading the Contributing Guide info (regarding jwt)
|
stevetangue
changed the title
stevetangue
changed the title
christianalfoni
approved these changes
Oct 15, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
This looks great! 👍 😄
Tested:
- Open profile page sandboxes
- Delete sandbox, which opens modal
- Cancel modal
- Confirm delete, it deletes it
This was referenced Oct 18, 2019
84 tasks
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
/src/app/pages/common/Modals/DeleteProfileSandboxModal/index.js@Saeris @christianalfoni
What is the current behavior?
| #2621 |
What steps did you take to test this? This is required before we can merge.
Tested via http://pr2744.build.csb.dev/s/new1. Sign in via token > My Profile > Sandboxes > Delete Sandbox