-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Embed redesign 2/n: Sidebar sections + Sandbox info #2731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[skip ci]
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/p96it9lj3 |
|
@DannyRuchtie Quick question: The redesign also introduces stats on an embedded sandbox. Should clicking on the like/fork icon trigger an action? (for comparison, the heart on app triggers a like, the fork doesn't do anything) |
|
It would be nice! |
or
|
|
Let's say it's nice to have. |
|
@DannyRuchtie Does this look like a good n+1 step to ship? |
|
This looks awesome!! A couple things I'd like some discussion on:
|
| height: 35px; | ||
| min-height: 35px; | ||
| background-color: rgba(0, 0, 0, 0.3); | ||
| background-color: ${props => props.theme['tab.inactiveBackground']}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that we're using themes here already!
Makes sense. But because of the big open in Codesandbox button and logo. It currently looks a bit cluttered. _
_ Two things:
|
sounds good 👍
Yep, haven't made my way to the tab bars yet. Does it look worse than what we have on production? Might make sense to wait for consistent heights before merging?
Of the sandbox name? I copied from the IDE file where it's 12. Just checked the Embed file to cross check and it's 11px there 😅. Can reduce that to 11 |
|
Superseded by #2791 |





The goal of this PR is to move closer to the final design without making the experience worse. (
n + 1 > n)Built on top of #2678
Part 1
Changes the color of the shell without changing the components. The goal of this PR is to move closer to the final design without making the experience worse. (n + 1 > n)
Implementation detail: Created a new VSCode theme that matches our design
Using it in embed. Had to modify a few components (2) to use the right keys
Part 2
Changes the structure of the sidebar by adding foldable sections + redesigned the sandbox info tab
Added stats to the sandbox info section
Demo
https://pr2731.build.csb.dev/embed/5pj49
What steps did you take to test this?
Checklist