Skip to content

Conversation

@siddharthkp
Copy link
Contributor

@siddharthkp siddharthkp commented Oct 7, 2019

Part 1

Changes the color of the shell without changing the components. The goal of this PR is to move closer to the final design without making the experience worse. (n + 1 > n)

Demo: https://pr2678.build.csb.dev/embed/rohv5

Implementation detail:

Created a new VSCode theme that matches our design

Using it in embed. Had to modify a few components (2) to use the right keys

What steps did you take to test this?

  • Testing embed applies new styles
  • Testing sandbox remains the same

Checklist

  • [NA] Documentation
  • Testing
  • Ready to be merged
  • [NA] Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 7, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-embed-black.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 7, 2019 13:00 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 14:35 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 14:36 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 15:18 Inactive
@vercel vercel bot temporarily deployed to staging October 10, 2019 07:12 Inactive
@vercel vercel bot temporarily deployed to staging October 10, 2019 09:22 Inactive
@vercel vercel bot temporarily deployed to staging October 10, 2019 09:53 Inactive
@siddharthkp
Copy link
Contributor Author

Superseded by #2731

@siddharthkp siddharthkp mentioned this pull request Oct 18, 2019
4 tasks
@MichaelDeBoey MichaelDeBoey deleted the embed-black branch December 16, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants