-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Notifications, showing, short selector a11y #2711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-client-git-fork-yeion7-notifications-a11y.codesandbox1.now.sh |
|
@CompuIves I've reopened this from #2652, maybe we could find a solution for outline styles and merge this change, sorry for the prev PR Could you check if the z-index and performance issues persist after upgrade |
d2de254 to
ac8f7d1
Compare
|
@CompuIves what do you think about this? use the same styles as user menu on hover items |
|
Read on the other PR that there was some performance issue! Is this still an issue? If so, please let me know if there's anything I can help with on the Reakit side. :) |
|
@CompuIves any chance of moving this PR forward? |
…to notifications-a11y
|
Build for latest commit 435bc57 is at https://pr2711.build.csb.dev/s/new. |



What kind of change does this PR introduce?
Refactor, reopen #2652
What is the current behavior?
The notifications has a few a11 issues
What is the new behavior?
What steps did you take to test this?
Checklist