-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Notifications, showing, short selector a11y #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-client-git-fork-yeion7-notifications-a11y.codesandbox1.now.sh |
|
@SaraVieira 👋 this PR is ready for review 😁 btw, thanks for review my last PRs |
SaraVieira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One day people CodeSandbox without a mouse and it will be thanks to you
|
I reverted this PR because I noticed some issues in the dashboard. It seems like the z-index wasn't set correctly: I also noticed that the performance of the modal itself went down a bit when moving the mouse over the items, this could either be because of the focus outline that pops in and out or something else. I also noticed this: Is there a way to make this more beautiful? Might need @DannyRuchtie input here, but I find the border to be quite ugly, and while I do see the usefulness from an a11y perspective here, I also think we can do better than just adding a blue border. |
|
oh no 😱 @CompuIves these problems happened in your local environment? seems like you have The focus style, I think is important to keep it, more details here, Maybe we could implement this trick for outline when use mouse, while we have a better outline |


What kind of change does this PR introduce?
Refactor
What is the current behavior?
The notifications has a few a11 issues
What is the new behavior?
What steps did you take to test this?
Checklist