Skip to content

Conversation

@silltho
Copy link
Contributor

@silltho silltho commented Oct 6, 2019

What kind of change does this PR introduce?

Refactor code for hacktoberfest #2621
@Saeris @christianalfoni @SaraVieira

What is the current behavior?

Sandbox/Editor/Workspace/Dependencies/AddVersion/index.js was using inject and observer from app/componentConnectors

What is the new behavior?

uses useOvermind from app/overmind

What steps did you take to test this?

ran yarn typecheckand yarn lint

Checklist

  • Documentation N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 6, 2019 20:19 Inactive
@vercel
Copy link

vercel bot commented Oct 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-cl-git-fork-silltho-refactor-workspace-depen-c98ade.codesandbox1.now.sh

@SaraVieira
Copy link
Contributor

SaraVieira commented Oct 7, 2019

Hey!

You need to go on this file https://github.com/codesandbox/codesandbox-client/blob/7c166dd82628f15c2576db0d3094c409313eb078/packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/index.js and chenge the import too as right now the pr deploy breaks :/

https://pr2671.build.csb.dev/s/new

@vercel vercel bot temporarily deployed to staging October 7, 2019 21:18 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 21:21 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 21:37 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 21:50 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 21:51 Inactive
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 8, 2019
@silltho
Copy link
Contributor Author

silltho commented Oct 9, 2019

Hey @SaraVieira,

Thank you for reviewing this pr. I think you have already fixed /packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/index.js? Anything else I should do to get this merged?

Greets from Austria

@CompuIves
Copy link
Member

Thanks a lot for contributing!! Merging in now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants