add an information in contributing doc to have the latest version of … #2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-clien-git-fork-mkamranhamid-doc-update-contr-5c1366.codesandbox1.now.sh |
SaraVieira
approved these changes
Oct 5, 2019
Contributor
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
Good catch! Thank you
Contributor
Author
|
Thank you so much this is my first open source contribution |
Contributor
Author
|
Can you please add #hacktoberfest in the label. @SaraVieira |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…yarn
What kind of change does this PR introduce?
Added a line in the doc contributing.md to have the latest version of yarn. I had yarn version
1.13and our app required1.19. When I didyarn installIt didn't work so I had to check and install the latest version of yarn and it fixed the error.What is the current behavior?
Currently, if you follow the instruction as I did and try
yarn installyou will probably end up in an errorWhat is the new behavior?
Now if you're following instruction and you see Its a requirement to have Node version
10.x.x. You will also see a point to have yarn latest versionWhat steps did you take to test this?
N/A
Checklist