Skip to content

chore: add "config", "revert" to prlint.json #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

chore: add "config", "revert" to prlint.json #8665

merged 2 commits into from
Mar 28, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 27, 2024

Description
There is a PR that contains only config changes.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis mentioned this pull request Mar 27, 2024
Merged
1 task
datamweb
datamweb reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding revert can also be useful.

@kenjis
Copy link
Member Author

kenjis commented Mar 27, 2024

@datamweb Added revert.

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Mar 27, 2024
@kenjis kenjis changed the title chore: add "config" to prlint.json chore: add "config", "revert" to prlint.json Mar 27, 2024
datamweb
datamweb approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank kenjis.

@kenjis kenjis merged commit e22b0c5 into codeigniter4:develop Mar 28, 2024
@kenjis kenjis deleted the update-prlint branch March 28, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @datamweb