Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Mar 26, 2024

Needs #8665

Description
By default, Config\Database::$tests is for SQLite3, and these values are different.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis marked this pull request as draft March 27, 2024 00:53
@kenjis kenjis added 4.5 database Issues or pull requests that affect the database layer labels Mar 27, 2024
@github-actions github-actions bot added the stale Pull requests with conflicts label Mar 28, 2024
@github-actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

By default, tests is for SQLite3, and these values are different.
@kenjis kenjis removed the stale Pull requests with conflicts label Mar 28, 2024
@kenjis kenjis marked this pull request as ready for review March 28, 2024 02:21
@kenjis
Copy link
Member Author

kenjis commented Mar 28, 2024

Rebased and ready for review.

Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be interesting to know that Laravel 11 has set the default database connection to SQLite.

@kenjis kenjis merged commit e131c46 into codeigniter4:4.5 Mar 28, 2024
@kenjis kenjis deleted the update-env branch March 28, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database Issues or pull requests that affect the database layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants