fix: Factories caching bug #8037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #8036 (comment)
$optionsare not saved in cacheDetails
This bug is hidden. Because when restoring the cache,
Config\Appis instantiated and calls:CodeIgniter4/system/Config/BaseConfig.php
Line 85 in da6492d
The above code calls
Factories::getOptions()and it callssetOptions()and setsself::$options['config'].Therefore after the instantiation,
Factories::$options['config']is always set.But this change removed
config(). So after the instantiation,Factories::$options['config']will be empty.When
$options['config']is empty,getOptions()callssetOptions()and it callsreset():CodeIgniter4/system/Config/Factories.php
Line 401 in da6492d
Checklist: