Skip to content

fix: make Factories final #8056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2023
Merged

fix: make Factories final #8056

merged 2 commits into from
Oct 21, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Oct 18, 2023

Description
See #8037 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.5 labels Oct 18, 2023
@kenjis kenjis mentioned this pull request Oct 18, 2023
Merged
5 tasks
@kenjis kenjis merged commit 45b1d68 into codeigniter4:4.5 Oct 21, 2023
@kenjis kenjis deleted the make-Factories-final branch October 21, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @michalsn