chore: [PHPStan] enable booleansInConditions #7943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
approved these changes
Sep 15, 2023
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
kenjis
force-pushed
the
phpstan-booleansInConditions
branch
from
d04e069 to
09062ec
Compare
samsonasik
reviewed
Sep 18, 2023
| 'path' => __DIR__ . '/system/Autoloader/FileLocator.php', | ||
| ]; | ||
| $ignoreErrors[] = [ | ||
| 'message' => '#^Only booleans are allowed in an if condition, string given\\.$#', |
Member
There was a problem hiding this comment.
Rector should can handle it:
https://getrector.com/demo/f64fdd76-8ad2-4af6-b57d-d8aa1ef366e8
with BooleanInIfConditionRuleFixerRector
Member
There was a problem hiding this comment.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implicit type conversion is prone to bugs.
Ref #7916
Checklist: