Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Sep 9, 2023

Description
To disallow empty() - it's a very loose comparison (see manual), it's recommended to use more strict one. See #7896 (comment)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis merged commit cc28c41 into codeigniter4:develop Sep 10, 2023
@kenjis kenjis deleted the add-phpstan-strict-rules-disallowedConstructs branch September 10, 2023 23:43
@kenjis kenjis changed the title chore: add phpstan-strict-rules disallowedConstructs chore: add phpstan-strict-rules and enable disallowedConstructs Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants