Skip to content

fix: types for common functions #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: types for common functions #7917

merged 1 commit into from
Sep 11, 2023

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Sep 10, 2023

Description
see #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

neznaika0
neznaika0 reviewed Sep 10, 2023
View reviewed changes
kenjis
kenjis reviewed Sep 11, 2023
View reviewed changes
@kenjis kenjis added the stale Pull requests with conflicts label Sep 11, 2023
@paulbalandan
Copy link
Member Author

paulbalandan commented Sep 11, 2023

Rebased.

@ddevsr ddevsr removed the stale Pull requests with conflicts label Sep 11, 2023
@kenjis kenjis merged commit 37ff3a4 into codeigniter4:develop Sep 11, 2023
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 11, 2023
@paulbalandan paulbalandan deleted the phpstan-helpers branch October 27, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

+1 more reviewer

@neznaika0 neznaika0 neznaika0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulbalandan @kenjis @neznaika0 @ddevsr