fix: types for common functions

Author: paulbalandan

phpstan-baseline.php

@@ -226,21 +226,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Commands/Utilities/Routes/AutoRouterImproved/AutoRouteCollector.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Function force_https\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Common.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Function helper\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Common.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Function timer\\(\\) has parameter \\$callable with no signature specified for callable\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Common.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method CodeIgniter\\\\ComposerScripts\\:\\:postUpdate\\(\\) has no return type specified\\.$#',
 	'count' => 1,

system/Common.php

@@ -474,6 +474,8 @@ function esc($data, string $context = 'html', ?string $encoding = null)
      * @param int $duration How long should the SSL header be set for? (in seconds)
      *                      Defaults to 1 year.
      *
+     * @return never|void
+     *
      * @throws HTTPException
      * @throws RedirectException
      */
@@ -590,7 +592,7 @@ function function_usable(string $functionName): bool
      *
      * @throws FileNotFoundException
      */
-    function helper($filenames)
+    function helper($filenames): void
     {
         static $loaded = [];
 
@@ -1139,6 +1141,8 @@ function stringify_attributes($attributes, bool $js = false): string
      * returns its return value if any.
      * Otherwise will start or stop the timer intelligently.
      *
+     * @phpstan-param (callable(): mixed)|null $callable
+     *
      * @return Timer
      */
     function timer(?string $name = null, ?callable $callable = null)