Skip to content

docs: add @phpstan-ignore-next-line in number_to_size() #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

docs: add @phpstan-ignore-next-line in number_to_size() #7645

merged 1 commit into from
Jul 3, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jul 3, 2023 •
edited
Loading

Description
phpstan 1.10.22

 ------ ------------------------------------------------------------------------------------- 
  Line   system/Helpers/number_helper.php                                                     
 ------ ------------------------------------------------------------------------------------- 
  27     Binary operation "+" between 0 and (array<int, string>|string) results in an error.  
 ------ -------------------------------------------------------------------------------------

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis merged commit 89292d8 into codeigniter4:develop Jul 3, 2023
@kenjis kenjis deleted the fix-phpstan-error-number_to_size branch July 3, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @datamweb