Merge pull request #7645 from kenjis/fix-phpstan-error-number_to_size

kenjis · web-flow · commit 89292d818aa0 · 2023-07-03T13:45:24.000+09:00
docs: add @phpstan-ignore-next-line in number_to_size()
diff --git a/system/Helpers/number_helper.php b/system/Helpers/number_helper.php
@@ -24,8 +24,10 @@ function number_to_size($num, int $precision = 1, ?string $locale = null)
     {
         // Strip any formatting & ensure numeric input
         try {
+            // @phpstan-ignore-next-line
             $num = 0 + str_replace(',', '', $num);
         } catch (ErrorException $ee) {
+            // Catch "Warning:  A non-numeric value encountered"
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,10 @@ function number_to_size($num, int $precision = 1, ?string $locale = null)`
`24`	`24`	`{`
`25`	`25`	`// Strip any formatting & ensure numeric input`
`26`	`26`	`try {`
	`27`	`+ // @phpstan-ignore-next-line`
`27`	`28`	`$num = 0 + str_replace(',', '', $num);`
`28`	`29`	`} catch (ErrorException $ee) {`
	`30`	`+ // Catch "Warning: A non-numeric value encountered"`
`29`	`31`	`return false;`
`30`	`32`	`}`
`31`	`33`